feat(record): declare inputs for the seven configurable record:* blocks, and curate six - #3027
Merged
Merged
Conversation
…ks, and curate six Seven record:* blocks shipped with renderers that read props but declared no inputs. That combination is the worst of both: the renderer honours `limit`, `severity`, `location` …, while every authoring surface — the designer panel, the AI vocabulary, the generated manifest — reports the block takes no configuration. #3013 recorded them as deliberately uncurated for exactly that reason. The declarations mirror what each renderer actually reads: record:activity 11 from RecordActivityComponentProps record:chatter 5 from RecordChatterComponentProps record:discussion 5 (same renderer, same inputs) record:alert 8 severity, title, body, visible, icon, action, dismissible, dismissKey record:quick_actions 7 actionNames, requiredPermissions, location, align, inline, variant, size record:history 3 limit, emptyText, unknownUserText record:reference_rail 1 hideEmpty inputs describe what an AUTHOR writes, which is a subset of what the renderer reads. `entries`, `loading` and resolved `actions` are injected by the host shell off RecordContext; declaring them would invite a model to hand-write the data the page is supposed to fetch. `aria` is omitted for the reason it is omitted on record:details — an accessibility escape hatch, not a layout choice. `location` takes its enum from the spec's ACTION_LOCATIONS rather than restating it, per #3019. Six of the seven join PUBLIC_BLOCKS: configurable and absent from the contract is the state #3006 was about. The contract goes 36 -> 42 tags, all resolving. record:chatter stays out — same renderer as record:discussion under a Salesforce-familiar name, kept for schemas already in the wild. Two spellings of one block is ambiguity an authoring model cannot resolve, so the vocabulary carries the spec's name. A test compares the two input lists, so the day they diverge the exclusion stops being justified and fails. A companion assertion requires every curated record:* tag to declare inputs. A curated tag with none reads as "takes no configuration" when the renderer in fact reads props — the same gap #3006 opened, pointed the other way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 30, 2026 11:36
os-zhuang
added a commit
that referenced
this pull request
Jul 30, 2026
…element:* blocks (#3065) Same gap #3027 closed for record:*, in the two namespaces next door: renderers that read real props while every authoring surface reported "takes no configuration". Declarations mirror what each renderer reads — page:tabs items, tabStyle (line/card/pill), position (top/left) page:card title, bordered, body (slot), footer (slot) page:accordion items, allowMultiple, variant (flush/card) element:text content, variant, align element:number object, aggregate, field, filter, format, prefix, suffix element:button label, action (inline ActionDef), variant, size, icon, iconPosition, disabled element:definition-list items, columns, inline element:repeater object, titleField, fields, filter, sort, limit, emptyText, divided page:section, page:footer and page:sidebar stay at zero inputs on purpose: their renderers render children/body and nothing else — like element:divider, they are genuinely prop-less containers, and inventing inputs for them would be the opposite falsehood. aria and className stay undeclared throughout, per the convention on record:details: escape hatches and styling pass-throughs, not authoring choices. element:button's registration also documents the split against action:button — inline ActionDef vs a declared action referenced by name — so the two stop reading as duplicates. Declaration only; no renderer behavior changes. Curation (which of these join PUBLIC_BLOCKS) is a separate change. Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven blocks #3013 parked as "no declared inputs" turned out to read props all along — the declarations were simply missing. That combination is the worst of both: the renderer honours
limit,severity,location…, while every authoring surface (designer panel, AI vocabulary, generated manifest) reports the block takes no configuration.What each renderer actually reads
Derived from the renderers and from
@object-ui/types, not invented:record:activityRecordActivityComponentPropsrecord:chatter/record:discussionRecordChatterComponentPropsrecord:alertrecord:quick_actionsrecord:historyrecord:reference_railWhat was deliberately left out
inputsdescribe what an author writes, which is a strict subset of what the renderer reads:entries,loading, resolvedactions— injected by the host shell offRecordContext. Declaring them would invite a model to hand-write the data the page is supposed to fetch.aria— omitted for the same reason it is omitted onrecord:details: an accessibility escape hatch, not a layout choice.className— styling pass-through, not declared on any sibling.locationtakes its enum from the spec'sACTION_LOCATIONSrather than restating the seven values, per #3019.Six get curated, one does not
Configurable and absent from the contract is precisely the state #3006 was about, so six join
PUBLIC_BLOCKS. The contract goes 36 → 42, all resolving:record:chatterstays out. It is the same renderer asrecord:discussionunder a Salesforce-familiar name, kept for schemas already in the wild. Two spellings of one block is ambiguity an authoring model has no way to resolve, so the vocabulary carries the spec's name.That exclusion is now falsifiable rather than asserted: a test compares the two input lists, so the day they diverge,
chatteris its own block being kept out of the vocabulary — the exact state this file exists to catch — and it fails.New guard, pointing the other way
Every curated
record:*tag must declare inputs. A curated tag with none reads as "this block takes no configuration" when the renderer in fact reads props — the same gap #3006 opened, mirrored. Curation and a configuration surface travel together.The old
keeps the deliberately-uncurated blocks unconfigurableassertion is gone with the reason it encoded.Full suite
733 passed | 1 skipped, lint 0 errors, type-check 40/40, changeset included.🤖 Generated with Claude Code
https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
Generated by Claude Code